Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border stroke for TYPE_CROSS check fields #1262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dadza
Copy link
Contributor

@dadza dadza commented Jan 23, 2025

Fixes #1261

Description of the new Feature/Bugfix

Added a stroke() call for the rectangle used to draw the field border in getAppearanceRadioCross.

Related Issue: #1261

Thank you,
Lucian chirita

Copy link
Contributor

@mkl-public mkl-public left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect,

  • the rectangle must only be stroked if a solid stroke border is selected while you stroke unconditionally,
  • the clip call must be before the stroke call if any, and
  • the newPath call in case of the on state must be dropped if the rectangle is stroked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Border of cross check field not visible in Chrome viewer
2 participants