pkg/core/session: Add WithReceiveTimeout SessionOpt

Current code does not retry enough time on receive (hard-coded to 1s)
and some devices (for example Intel SSDPE2KX040T8O) operation
such as "PSID Revert" takes ~15s.

This results always in a timeout error:

"method call timed out waiting for a response"

Exposing SessionOpt to override default 100*10ms polling for receive will
allow calling code to override these defaults.

pkg/core/session.go

@@ -67,6 +67,8 @@ type Session struct {
 	SeqLastAcked    int
 	SeqNextExpected int
 	ReadOnly        bool // Ignored for Control Sessions
+	ReceiveRetries  int
+	ReceiveInterval time.Duration
 }
 
 type ControlSession struct {
@@ -162,6 +164,13 @@ func WithMaxComPacketSize(size uint) ControlSessionOpt {
 	}
 }
 
+func WithReceiveTimeout(retries int, interval time.Duration) SessionOpt {
+	return func(s *Session) {
+		s.ReceiveRetries = retries
+		s.ReceiveInterval = interval
+	}
+}
+
 func WithHSN(hsn int) SessionOpt {
 	return func(s *Session) {
 		s.HSN = hsn
@@ -207,11 +216,13 @@ func NewControlSession(d drive.DriveIntf, d0 *Level0Discovery, opts ...ControlSe
 	c := NewPlainCommunication(d, hp, tp)
 	s := &ControlSession{
 		Session: Session{
-			d:     d,
-			c:     c,
-			ComID: ComIDInvalid,
-			TSN:   0,
-			HSN:   0,
+			d:               d,
+			c:               c,
+			ComID:           ComIDInvalid,
+			TSN:             0,
+			HSN:             0,
+			ReceiveRetries:  100,
+			ReceiveInterval: 10 * time.Millisecond,
 		},
 		HostProperties:           hp,
 		TPerProperties:           tp,
@@ -321,14 +332,16 @@ func (cs *ControlSession) NewSession(spid uid.SPID, opts ...SessionOpt) (*Sessio
 	// then and the call to NewSession() we would be out of sync. Oh well...
 
 	s := &Session{
-		MethodFlags:    cs.MethodFlags,
-		ProtocolLevel:  cs.ProtocolLevel,
-		d:              cs.d,
-		c:              cs.c,
-		ControlSession: cs,
-		ComID:          cs.ComID,
-		TSN:            0,
-		HSN:            -1,
+		MethodFlags:     cs.MethodFlags,
+		ProtocolLevel:   cs.ProtocolLevel,
+		d:               cs.d,
+		c:               cs.c,
+		ControlSession:  cs,
+		ComID:           cs.ComID,
+		TSN:             0,
+		HSN:             -1,
+		ReceiveRetries:  100,
+		ReceiveInterval: 10 * time.Millisecond,
 	}
 
 	for _, opt := range opts {
@@ -523,7 +536,8 @@ func (s *Session) ExecuteMethod(mc *method.MethodCall) (stream.List, error) {
 	// > response, any IF-RECV command for that ComID SHALL receive a ComPacket with a
 	// > Length field value of zero (no payload), an OutstandingData field value of 0x01, and a
 	// > MinTransfer field value of zero.
-	for i := 100; i >= 0; i-- {
+
+	for i := s.ReceiveRetries; i >= 0; i-- {
 		resp, err = s.c.Receive(s)
 		if err != nil {
 			return nil, err
@@ -534,7 +548,7 @@ func (s *Session) ExecuteMethod(mc *method.MethodCall) (stream.List, error) {
 		if i == 0 {
 			return nil, method.ErrMethodTimeout
 		}
-		time.Sleep(10 * time.Millisecond)
+		time.Sleep(s.ReceiveInterval)
 	}
 
 	reply, err := stream.Decode(resp)