Reduce lightning data's dependencies (#19026)

Lightning-AI · Nov 17, 2023 · 4e72dcc · 4e72dcc
1 parent 6e10642
commit 4e72dcc
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 13 deletions.
diff --git a/.azure/gpu-tests-fabric.yml b/.azure/gpu-tests-fabric.yml
@@ -26,9 +26,7 @@ pr:
       - "tests/tests_fabric/run_standalone_*.sh"
       - "tests/tests_pytorch/run_standalone_tests.sh" # used by fabric through a symlink
       - "requirements/fabric/**"
-      - "src/lightning/__about__.py"
       - "src/lightning/__init__.py"
-      - "src/lightning/__main__.py"
       - "src/lightning/__setup__.py"
       - "src/lightning/__version__.py"
       - "src/lightning/fabric/**"

diff --git a/.azure/gpu-tests-pytorch.yml b/.azure/gpu-tests-pytorch.yml
@@ -25,9 +25,7 @@ pr:
       - "examples/pytorch/basics/backbone_image_classifier.py"
       - "examples/pytorch/basics/autoencoder.py"
       - "requirements/pytorch/**"
-      - "src/lightning/__about__.py"
       - "src/lightning/__init__.py"
-      - "src/lightning/__main__.py"
       - "src/lightning/__setup__.py"
       - "src/lightning/__version__.py"
       - "src/lightning/pytorch/**"

diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml
@@ -54,9 +54,7 @@ subprojects:
       - "examples/pytorch/basics/backbone_image_classifier.py"
       - "examples/pytorch/basics/autoencoder.py"
       - "requirements/pytorch/**"
-      - "src/lightning/__about__.py"
       - "src/lightning/__init__.py"
-      - "src/lightning/__main__.py"
       - "src/lightning/__setup__.py"
       - "src/lightning/__version__.py"
       - "src/lightning/pytorch/**"
@@ -166,6 +164,9 @@ subprojects:
       - "requirements/data/**"
       - "src/lightning/data/**"
       - "src/lightning_data/*"
+      - "src/lightning/__init__.py"
+      - "src/lightning/__setup__.py"
+      - "src/lightning/__version__.py"
       - "tests/tests_data/**"
       - "examples/data/**"
       - "pyproject.toml" # includes pytest config
@@ -227,9 +228,7 @@ subprojects:
       - "tests/tests_fabric/run_standalone_*.sh"
       - "tests/tests_pytorch/run_standalone_tests.sh" # used by Fabric through a symlink
       - "requirements/fabric/**"
-      - "src/lightning/__about__.py"
       - "src/lightning/__init__.py"
-      - "src/lightning/__main__.py"
       - "src/lightning/__setup__.py"
       - "src/lightning/__version__.py"
       - "src/lightning/fabric/**"
@@ -318,9 +317,7 @@ subprojects:
   - id: "lightning: Store"
     paths:
       - ".github/workflows/ci-tests-store.yml"
-      - "src/lightning/__about__.py"
       - "src/lightning/__init__.py"
-      - "src/lightning/__main__.py"
       - "src/lightning/__setup__.py"
       - "src/lightning/__version__.py"
       - "src/lightning/store/**"

diff --git a/.github/workflows/ci-tests-data.yml b/.github/workflows/ci-tests-data.yml
@@ -11,6 +11,9 @@ on:
       - ".actions/*"
       - "requirements/data/**"
       - "src/lightning/data/**"
+      - "src/lightning/__init__.py"
+      - "src/lightning/__setup__.py"
+      - "src/lightning/__version__.py"
       - "tests/tests_data/**"
       - "pyproject.toml" # includes pytest config
       - ".github/workflows/ci-tests-data.yml"

diff --git a/.github/workflows/ci-tests-store.yml b/.github/workflows/ci-tests-store.yml
@@ -10,9 +10,7 @@ on:
     paths:
       - ".actions/*"
       - "requirements/store/**"
-      - "src/lightning/__about__.py"
       - "src/lightning/__init__.py"
-      - "src/lightning/__main__.py"
       - "src/lightning/__setup__.py"
       - "src/lightning/__version__.py"
       - "src/lightning/store/**"

diff --git a/requirements/data/data.txt b/requirements/data/data.txt
@@ -4,3 +4,4 @@
 lightning-utilities >=0.8.0, <0.10.0
 # to be able to include also PL 2.0 and preserve `>` needed for CI min version bypass
 torch >0.14.0, <2.2.0
+lightning-cloud
diff --git a/src/lightning/__setup__.py b/src/lightning/__setup__.py
@@ -48,7 +48,6 @@ def _prepare_extras() -> Dict[str, Any]:
     extras["app-extra"] = extras["app-app"] + extras["app-cloud"] + extras["app-ui"] + extras["app-components"]
     extras["app-all"] = extras["app-extra"]
     extras["app-dev"] = extras["app-all"] + extras["app-test"]
-    extras["data-data"] += extras["app-app"]  # todo: consider cutting/leaning this dependency
     extras["data-all"] = extras["data-data"] + extras["data-cloud"] + extras["data-examples"]
     extras["data-dev"] = extras["data-all"] + extras["data-test"]
     extras["store-store"] = extras["app-app"]  # todo: consider cutting/leaning this dependency