Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @override for files in src/lightning/fabric/accelerators #19068

Merged

Conversation

VictorPrins
Copy link
Contributor

@VictorPrins VictorPrins commented Nov 26, 2023

This PR adds the @override decorator for all files in src/lightning/fabric/accelerators (#18695).


📚 Documentation preview 📚: https://pytorch-lightning--19068.org.readthedocs.build/en/19068/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Merging #19068 (bbda843) into master (af852ff) will decrease coverage by 28%.
Report is 3 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19068      +/-   ##
==========================================
- Coverage      82%      54%     -28%     
==========================================
  Files         443      438       -5     
  Lines       36573    36509      -64     
==========================================
- Hits        29811    19705   -10106     
- Misses       6762    16804   +10042     

@awaelchli awaelchli added code quality community This PR is from the community labels Nov 27, 2023
@awaelchli awaelchli added this to the 2.2 milestone Nov 27, 2023
@mergify mergify bot added the ready PRs ready to be merged label Nov 27, 2023
@awaelchli awaelchli merged commit e30401a into Lightning-AI:master Nov 27, 2023
119 checks passed
@VictorPrins VictorPrins deleted the feature/#18695_fabric/accelerators branch November 27, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality community This PR is from the community fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants