Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): emergency bump docformatter #20352

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(lint): emergency bump docformatter #20352

merged 1 commit into from
Oct 21, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 19, 2024

What does this PR do?

Addressing:

build attempt 1...
    => error
    An error has occurred: InvalidManifestError: 
    ==> File /pc/clone/jNZWZVRSTLq-4hbwuef7PA/.pre-commit-hooks.yaml
    ==> At Hook(id='docformatter-venv')
    ==> At key: language
    =====> Expected one of conda, coursier, dart, docker, docker_image, dotnet, fail, golang, haskell, lua, node, perl, pygrep, python, r, ruby, rust, script, swift, system but got: 'python_venv'
    Check the log at /pc/pre-commit.log
build attempt 2...
    => error
    An error has occurred: InvalidManifestError: 
    ==> File /pc/clone/jNZWZVRSTLq-4hbwuef7PA/.pre-commit-hooks.yaml
    ==> At Hook(id='docformatter-venv')
    ==> At key: language
    =====> Expected one of conda, coursier, dart, docker, docker_image, dotnet, fail, golang, haskell, lua, node, perl, pygrep, python, r, ruby, rust, script, swift, system but got: 'python_venv'
    Check the log at /pc/pre-commit.log

ref: PyCQA/docformatter#287

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @tchaton

@Borda Borda added the priority: 0 High priority task label Oct 19, 2024
Copy link
Contributor

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Oct 21, 2024
@Borda Borda merged commit af19dda into master Oct 21, 2024
15 of 16 checks passed
@Borda Borda deleted the ci/lint branch October 21, 2024 09:53
Borda added a commit that referenced this pull request Nov 1, 2024
lantiga pushed a commit that referenced this pull request Nov 12, 2024
MrWhatZitToYaa pushed a commit to MrWhatZitToYaa/pytorch-lightning that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants