Add Review Move Icons + LRU Caching For Game Review #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few things that seemed nice from a user perspective so I did a little hacking, this PR is meant to do a few small things:
In
chess_review.py
it uses a platform specific branch to select the extension forstockfish_path
, which closes stockfish_path in chess_review.py assumes .exe extension #5It changes the
book
move classification color to besaddlebrown
which I personally found to be more appealing, but can be dropped as its a matter of opinion. Similarly, I made a slight change to the "selected" color for the move containers on the right sidebar (to avoid interference with move classification icon visibility), it is now a little darker than the hover color.Adds small move classification icons next to each move for a subset of move classifications (see the
display_classes
array inanalysis.html
. See the image below for an example of how this renders.I added a
--debug
flag for developers so that we can more easily switch between dev and "prod" modes for developers.