feat(squad): use FA for icons (#4165)

* feat(squad): use FA for icons

* alt is not applicable to this......

components/squad/commons/squad_row.lua

@@ -8,6 +8,7 @@
 
 local Class = require('Module:Class')
 local Flags = require('Module:Flags')
+local Icon = require('Module:Icon')
 local Logic = require('Module:Logic')
 local Lua = require('Module:Lua')
 local OpponentLib = require('Module:OpponentLibraries')
@@ -22,9 +23,8 @@ local Variables = require('Module:Variables')
 local SquadUtils = Lua.import('Module:Squad/Utils')
 local Widget = Lua.import('Module:Infobox/Widget/All')
 
-local ICON_CAPTAIN = '[[File:Captain Icon.png|18px|baseline|Captain|link=Category:Captains|alt=Captain'
-	.. '|class=player-role-icon]]'
-local ICON_SUBSTITUTE = '[[File:Substitution.png|18px|baseline|Sub|link=|alt=Substitution|class=player-role-icon]]'
+local ICON_CAPTAIN = Icon.makeIcon{iconName = 'captain', hover = 'Captain'}
+local ICON_SUBSTITUTE = Icon.makeIcon{iconName = 'substitute', hover = 'Substitute'}
 
 ---@class SquadRow
 ---@operator call: SquadRow

standard/icon.lua

@@ -11,7 +11,14 @@ local Logic = require('Module:Logic')
 
 local Icon = {}
 
----@param args {iconName: string, color: string?, screenReaderHidden: boolean?, hover: string?, size: integer|string?}
+---@class IconArgs
+---@field iconName string
+---@field color string?
+---@field screenReaderHidden boolean?
+---@field hover string?
+---@field size integer|string|nil
+
+---@param args IconArgs
 ---@return string?
 function Icon.makeIcon(args)
 	local icon = IconData[(args.iconName or ''):lower()]

standard/icon_data.lua

@@ -72,4 +72,8 @@ return {
 
 	-- Usage: buildtime, duration, cooldown, ...
 	time = 'far fa-clock',
+
+	-- Usage: Sqaud Table
+	captain = 'fas fa-crown',
+	substitute = 'fas fa-people-arrows',
 }