Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some icons in MatchPage are always in lightmode #5346

Closed
ElectricalBoy opened this issue Jan 19, 2025 · 1 comment · Fixed by #5348
Closed

Some icons in MatchPage are always in lightmode #5346

ElectricalBoy opened this issue Jan 19, 2025 · 1 comment · Fixed by #5348
Labels
c: match2 g: dota2 DOTA2 g: leagueoflegends League of Legends

Comments

@ElectricalBoy
Copy link
Collaborator

Original report on Discord

|interview= link icon is always in lightmode in LoL MatchPage
screenshot taken in https://liquipedia.net/leagueoflegends/Match:ID_LCKCup25W1_0002
Image

same issue observed with |interview= link icon and statistics link icon in Dota 2 MatchPage
screenshot taken from a preview
Image
@hjpalpha
Copy link
Collaborator

css used to invert these icons usually:

Lua-Modules/stylesheets/commons/Miscellaneous.less

Line 2206 in 710b7b9

Template: Darkmode 32px icons

where we might want to add vodlink class:

Lua-Modules/components/match2/wikis/leagueoflegends/match_page_template.lua

Line 37 in 710b7b9

<div class="match-bm-lol-match-additional-list">{{#parsedLinks}}[[{{icon}}|link={{link}}|15px|{{text}}]]{{/parsedLinks}}</div>

(basically same on dota2)

(on mobile so can't test anything in a reasonable fashion atm)

@hjpalpha hjpalpha mentioned this issue Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: match2 g: dota2 DOTA2 g: leagueoflegends League of Legends
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(match2): add darkmode support to link icons on matchPages Liquipedia/Lua-Modules
2 participants
@ElectricalBoy @hjpalpha