Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(match2): add darkmode support to link icons on matchPages #5348

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

hjpalpha
Copy link
Collaborator

resolves #5346

Summary

add the vodlink class to the div wrapper that is around the icons so they get inverted in darkmode

alternative solution would be to append both used classes at

& .vodlink img,
.group-table-header-right img {

How did you test this change?

browser dev tools

@hjpalpha hjpalpha requested a review from Rathoz January 20, 2025 06:55
@Rathoz Rathoz merged commit 21d5605 into main Jan 20, 2025
5 checks passed
@Rathoz Rathoz deleted the darkmode-icons-matchpage branch January 20, 2025 08:39
@ElectricalBoy ElectricalBoy added g: dota2 DOTA2 g: leagueoflegends League of Legends labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some icons in MatchPage are always in lightmode
3 participants