refactor(match2): Add often used functions to commons #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2024
Rathoz
reviewed
Apr 2, 2024
Co-authored-by: Rikard Blixt <[email protected]>
Co-authored-by: Rikard Blixt <[email protected]>
Co-authored-by: Rikard Blixt <[email protected]>
Co-authored-by: Rikard Blixt <[email protected]>
hjpalpha
added a commit
that referenced
this pull request
Apr 2, 2024
Rathoz
reviewed
Apr 2, 2024
mbergen
reviewed
Apr 2, 2024
Rathoz
reviewed
May 3, 2024
Co-authored-by: Rikard Blixt <[email protected]>
Rathoz
reviewed
May 3, 2024
Co-authored-by: Rikard Blixt <[email protected]>
Rathoz
approved these changes
May 3, 2024
Rathoz
deleted the
add-often-used-functions-to-commons-match2-input-processing
branch
Rathoz
pushed a commit
that referenced
this pull request
May 6, 2024
… - part 1/2 (#4118) * indent fix * splitgate * zula * wot * wildrift * val * sideswipe * rl * ow * Brkts/WikiSpecific * fix: lol Brkts/WikiSpecific * mobilelegends * rl: MatchGroup/Display/Bracket/Custom * lol: bm * lol: input * dota2 * tetris * trackmania * shut waning in apex * pokemon * use #4121 * kick unused require * as per changes in #4121 * as per changes in 4121 * shut up you damn anno warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add functions that are often repeated in match2 custom input processing to commons
Module:MatchGroup/Input.The idea is to extend #4118 and #4120 to also remove those duplicate code snipets and use the in this PR added commons functions instead if they are identical.
How did you test this change?
N/A, copied from R6 and not used anywhere as of now