feat(tier): Add isValidTierType
#4358
Draft
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
commented
Jun 19, 2024
Comment on lines
+67
to
+68
| if String.isEmpty(tierType) then return true end | ||
|
|
There was a problem hiding this comment.
Suggested change
| if String.isEmpty(tierType) then return true end |
Comment on lines
+45
to
+46
| assert.is_true(Tier.isValidTierType('')) | ||
| assert.is_true(Tier.isValidTierType()) |
There was a problem hiding this comment.
Suggested change
| assert.is_true(Tier.isValidTierType('')) | |
| assert.is_true(Tier.isValidTierType()) | |
| assert.is_false(Tier.isValidTierType('')) | |
| assert.is_false(Tier.isValidTierType()) |
That's a really good question.. Since empty tiertype is both a valid tiertype, but also an indication of no special tiertype. 🤔 |
|
modules discussion:
any further opinion? @Rathoz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggestion for a resolve of #4357
Summary
Add
isValidTierTypefucntion to tier moduleHow did you test this change?
sandbox on sc2 + test cases