-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(standard): one import for most of the standard lib #4504
base: main
Are you sure you want to change the base?
Conversation
Not familiar enough with the system, does this have any sizable impact on performance over importing just the ones needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not opposed
means lots of cleanup though
Negligible, Vogan did some tests a long time ago on it. |
Maybe something like this https://liquipedia.net/commons/Module:Sandbox/LuckeLucky/test2 StandartUsage
Result |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from modules sync:
- generally a good idea
- we think making it globals might be nice
- some of the included modules are not used that super often, so we think not including them here is better for now (if we see them being used more often we always can add them then)
Summary
What's everyone's opinion on this?
How did you test this change?