feat(match2): Add GOALS support #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FIFA version will not be accpected as is, as FIFA contains a ton of non-standard functionality. Please motivate the need for all of them with examples |
Rathoz
reviewed
Oct 30, 2024
Rathoz
reviewed
Oct 31, 2024
Rathoz
reviewed
Oct 31, 2024
currently not taking effect, still 1/0
I saw CrossFire had a change for those BO1 stuff early, so I try to brought over this to see if it fixes. Currently before this change the Storage do not store bestofs at all if |bestof= is not exactly set in each match, if not set it stores "0" and causes Bo1 scores to not work
Rathoz
reviewed
Oct 31, 2024
Rathoz
reviewed
Oct 31, 2024
Rathoz
reviewed
Oct 31, 2024
|
Nice, and now you remove all unused functionality from teh match summary |
Appreciate any pointers here if I forgot to remove any part I do want a way to fill that empty space in the middle, something like this, but idk how to |
|
Use battlerite |
do I need to rework other parts to get it working? my first attempt returns error at gameIndex (nil value) since both seems very different one is Widget based the other is addElement |
|
Use all of battlerite, and nothing else |
Rathoz
reviewed
Nov 1, 2024
based on GeoGuessr
Rathoz
reviewed
Nov 4, 2024
Rathoz
reviewed
Nov 5, 2024
Rathoz
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I port it over last year and forgot to revisit it
GOALS is a soccer game
so I decide to update the paste by using the current version of EA SPORTS FC Setup (recently updated October 17) without touching any edits yet, given its same game genre
How did you test this change?
LIVE https://liquipedia.net/goals/GOALS_Community_Cup/2
DEV https://liquipedia.net/goals/User:Hesketh2