Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(match table) Add option useShortName #5097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbergen
Copy link
Collaborator

@mbergen mbergen commented Nov 15, 2024

Summary

Request on discord
I agree that tickername is a weird choice for such a list, as it usually has a context (ongoing/recent/upcoming games, so a set timeframe) and is thus lacking e.g. years

How did you test this change?

dev
image

@mbergen mbergen added the c: match_table Match Table for on /Matches pages or "Recent Matches" sections label Nov 15, 2024
@mbergen mbergen requested a review from hjpalpha November 15, 2024 08:45
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay for me

@mbergen mbergen requested a review from Rathoz November 15, 2024 10:18
@mbergen mbergen force-pushed the matchtable-shortname branch from 6a146af to e6658a4 Compare December 19, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: match_table Match Table for on /Matches pages or "Recent Matches" sections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants