Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transfers): Add new type to support tournament leave #5103

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fregerson
Copy link
Collaborator

Summary

Added a new type for player leave as they did not represent a team at a tournament. This is accompanied by some wording change as well when used in SquadAuto templates

How did you test this change?

/dev/freg, tested on Honor of Kings wiki live

Added a new type for player leave as they did not represent a team at a tournament
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if tested

@fregerson
Copy link
Collaborator Author

Any update?

@fregerson
Copy link
Collaborator Author

Asking if anything else is needed from me here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants