feat(match2): Support the use of playall instead of bestof #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new type for player leave as they did not represent a team at a tournament
Update transfer_references.lua
Added a new type for player leave as they did not represent a team at a tournament
hjpalpha
reviewed
Nov 27, 2024
components/match2/wikis/ageofempires/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/counterstrike/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
|
How commons would thise be? If it's only a few matches one can always set |
Used for quite a number of recent non-official tournaments, we have not had the manpower to cover many of those, but thought it was something that could be used as an alternative for best of |
hjpalpha
reviewed
Dec 2, 2024
Rathoz
reviewed
Dec 3, 2024
Co-authored-by: Rikard Blixt <[email protected]>
Rathoz
reviewed
Dec 3, 2024
|
Reverted to the proposal where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempted to create and store a new variable
playallfor Match Series that requires teams to play out a fixed number of games (instead of a bestof)How did you test this change?
dev