feat(Links): Adding support for various Chess-related links #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hesketh2
requested review from
hjpalpha and
Rathoz
and removed request for
hjpalpha
Rathoz
reviewed
Dec 20, 2024
is to be done via PR in this repo so yes you can^^ |
for when inputting in Infobox gives you a different preset url, then in a match gives you another different one
|
I updated it to have 3 versions
|
hjpalpha
approved these changes
Dec 21, 2024
Hesketh2
changed the title
|
I will expand this PR to include two more chess website : 365Chess and Chessgames |
hjpalpha
requested changes
Dec 24, 2024
Hesketh2
changed the title
hjpalpha
reviewed
Dec 24, 2024
files in commons
hjpalpha
approved these changes
Dec 24, 2024
Hesketh2
changed the title
|
Lichess and FIDE's official site will be added to this later on so 5 new additions total. |
hjpalpha
approved these changes
Dec 28, 2024
* Update Icons.less InfoboxIcon for FIDE * Update links.lua Fide profile link * Update links_priority_groups.lua FIDE link priority
hjpalpha
changed the title
|
All should be added now alongside the uploaded icons and Infoboxes, should be now ready for review Every added link except FIDE will have match usage hence match icons |
|
Chess is not a wiki (yet), hence will not add stuff yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In future for chess wiki, this is also intended to be used within the match summary popup as well (like HLTV/VLR) as well as Infobox Icon too
Update: Includes 365Chess and Chessgames, all three will be used for Chess wiki, actually it's already in use for some of pre-documentation help
Update 2: also Includes Lichess and FIDE's official site as well, all 5 would see usage in case one doesnt provide the needed stats
|chesscom=|365chess=|chessgames=|fide=|lichess=Note: Fide is not used on match, but only for Infobox
How did you test this change?
How do I test link icons to begin with? I only recall the files that I need to edit