feat: change var for bg-first

[iamentry]

Summary

The current var for bg-first is unreadable in darkmode so this switches to a more readable version. I'm not sure if this is the intended use case for achievement-placement-1 but it looks good IMO. The attached images display the PR's changes via the "First" text. You can see what the current version is here: https://liquipedia.net/commons/Template:Bgcolortext

How did you test this change?

inspect tools

[hjpalpha]

why change the fallback value?

[iamentry]

why change the fallback value?

That is the fallback value for the class I changed it to

[hjpalpha]

why change the fallback value?

That is the fallback value for the class I changed it to

that doesn't mean you need to change the fallback value at all ...

[hjpalpha]

is it tested on plain pages?
your screenshots only show it on green stuff

[iamentry]

is it tested on plain pages? your screenshots only show it on green stuff

[iamentry]

why change the fallback value?

That is the fallback value for the class I changed it to

that doesn't mean you need to change the fallback value at all ...

Changed back to the original fallback

[hjpalpha]

fwiw:

• this doesn't affect td, tr, div due to the other definitions of bg-first having higher specificity in their definition
• for td we use --prize-pool-gold var

(both of those remarks refer to Prizepooltable.less)

[iamentry]

fwiw:

* this doesn't affect td, tr, div due to the other definitions of bg-first having higher specificity in their definition

* for td we use `--prize-pool-gold` var

(both of those remarks refer to Prizepooltable.less)

all the other definitions are readable in dark mode afaik, so that's fine.

[liquidely]

What's the status of this PR now since it's been open a while? Ready to review?

[hjpalpha]

imo okay

[iamentry]

What's the status of this PR now since it's been open a while? Ready to review?

Ready to review