Simplify if statements

Liquipedia · Apr 20, 2024 · ce51cfe · ce51cfe
1 parent 3554f28
commit ce51cfe
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/src/SpecialPage/SpecialResourceLoaderArticles.php b/src/SpecialPage/SpecialResourceLoaderArticles.php
@@ -152,7 +152,6 @@ private function addPage() {
 	 */
 	public function addPageCB( $formData ) {
 		$output = $this->getOutput();
-		$store = true;
 		if (
 			(
 				!( substr( $formData[ 'Page' ], -4 ) === '.css' || substr( $formData[ 'Page' ], -5 ) === '.less' )
@@ -165,9 +164,7 @@ public function addPageCB( $formData ) {
 				. $this->msg( 'resourceloaderarticles-error-page-invalid' )->text()
 				. '</div>'
 			);
-			$store = false;
-		}
-		if ( $store ) {
+		} else {
 			$dbw = wfGetDB( DB_PRIMARY );
 			$dbw->insert(
 				'resourceloaderarticles',
@@ -242,7 +239,6 @@ private function editPage( $id ) {
 	 */
 	public function editPageCB( $formData ) {
 		$output = $this->getOutput();
-		$store = true;
 		if (
 			(
 				!( substr( $formData[ 'Page' ], -4 ) === '.css' || substr( $formData[ 'Page' ], -5 ) === '.less' )
@@ -255,9 +251,7 @@ public function editPageCB( $formData ) {
 				. $this->msg( 'resourceloaderarticles-error-page-invalid' )->text()
 				. '</div>'
 			);
-			$store = false;
-		}
-		if ( $store ) {
+		} else {
 			$dbw = wfGetDB( DB_PRIMARY );
 			$dbw->update(
 				'resourceloaderarticles',