Enabling ES6 for ResourceLoader validation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rathoz
reviewed
Jan 18, 2024
Co-authored-by: Rikard Blixt <[email protected]>
…ticles into es6-enabling
FO-nTTaX
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables the loading of ES6 scripts using the resource loader by overriding the current script validation with the new one developed by MediaWiki.
It is a duplicate of the new MediaWiki version and uses Peast for the script validation.
Testing
Tested on my dev environment using script from Lua Modules and some tests using arrow functions (proper to ES6)
Notes
The composer.local.json must be updated to consider this new dependency (peast) to work.