Add missing RBAC and error handler for secret update

Signed-off-by: Ondrej Vasko <[email protected]>
Lirt · Nov 7, 2023 · 451cda1 · 451cda1
1 parent 11ad46d
commit 451cda1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/chart/templates/rbac.yaml b/chart/templates/rbac.yaml
@@ -25,11 +25,13 @@ rules:
       - get
       - create
       - watch
+      - update
   - apiGroups: [""]
     resources:
       - namespaces
     verbs:
       - watch
+      - list
 
 ---
 apiVersion: rbac.authorization.k8s.io/v1

diff --git a/main.go b/main.go
@@ -58,7 +58,14 @@ func watchSourceSecret(client *kubernetes.Clientset, watchApi watchapi.Interface
 						logger.Info("Skip updating secret in source namespace")
 						continue
 					}
-					helpers.UpdateExistingSecret(client, logger, event.Object.(*v1.Secret), sourceSecretName, ns.Name)
+					err = helpers.UpdateExistingSecret(client, logger, event.Object.(*v1.Secret), sourceSecretName, ns.Name)
+					if err != nil {
+						logger.Error("failed to update secret",
+							zap.String("name", sourceSecretName),
+							zap.String("namespace", ns.Name),
+							zap.Error(err),
+						)
+					}
 				}
 			}
 		}