Introduce Option to omit VolumeBackup container option #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Lamp <[email protected]>
|
Hello, thank you for PR. I will need some days to get to this due to business trips. Thank you for patience. |
|
Hello @modzilla99, I apologize. I completely forgot about this PR. Let me recheck this. Is the PR ready? It still has |
|
The idea makes sense to me. |
|
@modzilla99 |
modzilla99
changed the title
|
Hi, there are conflicts in the PR. Can you please fix them? Also you can use comment to let me know when it's fixed so that I'm notified. It will be faster to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Ceph RBD Backup driver, the container attr set when creating a VolumeSnapshot has to either correspond to the backup rbd pool or be omitted. Many users might not know which rbd_pool that is, so it should just be omitted in that case. Similar to #107
Since most OS clouds use ceph, it might even make sense to omit it by default and let the user have to explicitly set it. Any thoughts?