Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin translations webapp_consent #3577

Merged

Conversation

LiteFarm-eng
Copy link
Contributor

New Crowdin pull request with translations of webapp_consent

@LiteFarm-eng LiteFarm-eng requested review from a team as code owners December 6, 2024 03:39
@LiteFarm-eng LiteFarm-eng requested review from antsgar and Duncan-Brain and removed request for a team December 6, 2024 03:39
Copy link
Collaborator

@kathyavini kathyavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore but keep open so we don't keep regenerating it with each pull 🙏

@github-actions github-actions bot force-pushed the l10n_crowdin_translations_integration_webapp_consent branch from d53bb43 to 56fbfac Compare December 12, 2024 20:15
@github-actions github-actions bot force-pushed the l10n_crowdin_translations_integration_webapp_consent branch from 56fbfac to 730b186 Compare January 13, 2025 18:41
@github-actions github-actions bot force-pushed the l10n_crowdin_translations_integration_webapp_consent branch from 730b186 to 381ca5e Compare January 13, 2025 18:50
kathyavini
kathyavini previously approved these changes Jan 13, 2025
Copy link
Collaborator

@kathyavini kathyavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Duncan-Brain and @SayakaOno I did the following to the CrowdIn pull:

  1. Removed Polish
  2. Restored the integration version of es/en/fr/pt since that is what we had approved
  3. Fixed a redundant line in English that Larisse spotted

However, because I did #2 and #3 with my pre-commit linter active, it fixed the markdown trailing spaces. I'm okay with this, but if you can think of a reason it's not a good idea (I guess it would change the last edited date if that's a property we care about 🤔 ), I will disable my pre-commit and redo.

Edit: Blech I see the CrowdIn bot also did something very annoying with the redundant "for further information" line (inserted in in English into the other files); will fix that!

@@ -84,6 +84,10 @@ LiteFarm nutzt die Managementinformationen, die Sie in die App eingeben, um Erke

- Farmspezifische Details: bevorzugte Einheiten (z.B. metrische oder imperiale); Währung; ob der Betrieb eine Zertifizierung anstrebt; Zertifizierer; Beet-Eigenschaften; Reihenattribute.

- • Angaben zum Tier: Name des einzelnen Tieres oder der Tiergruppe, Art, Rasse, Geschlecht, Einbringungs- oder Geburtsdatum und andere Angaben zur Identifizierung.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the bullet point or is it fine...?
I'm okay with everything else too!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Yes, let's remove it. I think we have license to fix up formatting as needed 🙂

@kathyavini kathyavini closed this Jan 13, 2025
@kathyavini kathyavini reopened this Jan 13, 2025
@SayakaOno SayakaOno added this pull request to the merge queue Jan 14, 2025
Merged via the queue into integration with commit b598a43 Jan 14, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants