Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing frontend GitHub workflows after 3.7.3 patch and backport #3641

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented Jan 2, 2025

Description

This PR is to fix the address the Ignoring not compatible lockfile error our webapp automated tests are now showing.

Errors here:

I thought the lockfile just had to be regenerated, but there is apparently also a pnpm version incompatibility that has to be resolved. Failing tests were fixed on 6.26.1 but the dockerfiles, passing tests, etc. are on version: latest.

I have

  • put failing tests on latest
  • regenerated the pnpm lockfile using pnpm@latest (v9.15.2)

But I'm surprised we don't want to fix our pnpm version so I am drafting the PR until we have decided that.

Update: we do want to fix the pnpm version but it does not have to be right now; I have created a Jira ticket for fixing pnpm to an exact version

Jira link: none

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini requested review from a team as code owners January 2, 2025 18:21
@kathyavini kathyavini requested review from antsgar and SayakaOno and removed request for a team January 2, 2025 18:21
@kathyavini kathyavini marked this pull request as draft January 2, 2025 18:33
@kathyavini kathyavini changed the title Regenerate pnpm-lock.yaml after 3.7.3 patch and backport Fix failing frontend GitHub workflows after 3.7.3 patch and backport Jan 2, 2025
@kathyavini kathyavini self-assigned this Jan 2, 2025
@kathyavini kathyavini added the bug Something isn't working label Jan 2, 2025
@kathyavini kathyavini marked this pull request as ready for review January 6, 2025 16:39
Copy link
Collaborator

@SayakaOno SayakaOno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@antsgar antsgar added this pull request to the merge queue Jan 7, 2025
Merged via the queue into integration with commit 5951cec Jan 7, 2025
5 checks passed
@antsgar antsgar deleted the regenerate-pnpm-lock-patch-3.7.3 branch January 7, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants