Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom user-agent for Refresher client #64

Merged
merged 1 commit into from
May 12, 2024

Conversation

crystall1nedev
Copy link
Contributor

This PR adds a custom user-agent for the Refresher app, closing #60.

The user-agent is built with Refresher/<autodiscover-version>. This was chosen over other options for a few reasons:

  • This UA will be unique to Refresher, and servers can whitelist Refresher clients
    • Useful against repeated spam from bots and such
  • Matching the autodiscover version can be useful server-side
    • Requests can be denied, for example, if something that is required is not available in an older version
      • v1 vs v2 is a great example of this!
  • The user-agent only needs to be updated when the AutoDiscover version changes

@jvyden jvyden self-requested a review May 12, 2024 05:24
Copy link
Member

@jvyden jvyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably won't implement any whitelisting/blacklisting/blocking/anything of the sort since I don't believe those limitations really need to exist, but this is indeed probably useful to someone to have. 😅

@jvyden jvyden merged commit e077327 into LittleBigRefresh:main May 12, 2024
2 checks passed
@crystall1nedev crystall1nedev deleted the user-agent branch May 12, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants