Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup releases and create universal2 binaries #67

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

crystall1nedev
Copy link
Contributor

  • Uploads .tar.gz for releases instead of tarballs inside of zips
  • Creates a universal2 binary for macOS instead of separated architectures

* Use tarballs for releases instead of zips

No double acrhive since this isn't a workflow

* Whoops, need to change filenames

* Skill issue

* bre

* will this work?

* what is the issue?

* this should work

* bruh

* bruh x2

* bruh x3

* bruh x4

* bruh x5

* bruh x6

* Attempt 1 for universal2 builds

* Now bring this to the releases...
@crystall1nedev crystall1nedev changed the title Fixup releases and create universal2 binaries (#2) Fixup releases and create universal2 binaries May 31, 2024
@crystall1nedev
Copy link
Contributor Author

crystall1nedev commented May 31, 2024

Releases after this change:
Screenshot

Non-release workflows remain the same - they need to be a tarball inside of a zip to work around an issue with executable bits.

Now finally, are this PR everything should be addressed in #62.

.github/workflows/dotnet.yml Show resolved Hide resolved
Signed-off-by: Eva Isabella Luna <[email protected]>
Signed-off-by: Eva Isabella Luna <[email protected]>
@crystall1nedev crystall1nedev requested a review from Beyley June 1, 2024 21:21
@Beyley Beyley merged commit 6bfc9d8 into LittleBigRefresh:osx Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants