This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
Implement CRUD operations for User Service #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikilark
reviewed
Nov 11, 2021
There was a problem hiding this comment.
As for me, it looks more like POC for using firebase in python, than sth about user_service
What these models have in common with our (real) application? Where do we will store avatars, profile description, etc? Password user_service will get already hashed, I didn't see you handled this
|
@ZhavoronkovN hold on. Let me push new commits first) |
|
Note: for the tests I have created a separate database in Firebase on my personal account. |
nikilark
approved these changes
Nov 18, 2021
arihilmir
reviewed
Nov 20, 2021
arihilmir
approved these changes
Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes affect user service only and include CRUD interface for User Service. It operates with the Firebase Real Time database (No SQL database) via client library.
Plus, I have wrapped user service with docker in order to make a deployment more smoth and painless.
Publisher and subscriber python files the way we communicate with Google Pub/Sub in python.
Database connector provides an CRUD interface for user profile information.
Dockerfile simply copy all scripts in the one directory and run main.py as an entry point for the whole user service application. There are just a few lines of code for now. More will be added later.
Issues
LFND-44 | Implement CRUD operations for User Service
How Has This Been Tested?
In order to test this changes you need to add json credentials to the user service root directory (you can download them from google cloud and firebase).
Checklist: