Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add live poly a and skip poly a feature #352

Closed
wants to merge 1 commit into from

Conversation

satriobio
Copy link

  • crude, signal-space, live poly-a length estimation
  • skip basecall when chunks is poly-a sequence

@Adoni5
Copy link
Contributor

Adoni5 commented May 7, 2024

HI @satriobio, can you add docstrings to the function and module for Stringray, so it's easier to understand what it is doing?

A good example is targets.py, with the module level docstring at the top and the functions having individal docstrings.

Also code like this that doesn't rely on outside tools too much is a great candidate for Unit/DocTests - examples of which can be found here

>>> is_empty(42)
False
>>> is_empty("Hello, world!")
False
>>> is_empty([])
True
>>> is_empty({})
True
>>> is_empty([1, 2, 3])
False
>>> is_empty({"a": 1, "b": 2})
False
>>> is_empty([[], [], []])
False
>>> is_empty([{}, {}])
False
>>> is_empty(None)
False

We use pytest for performing these tests, which can be set up locally as detailed in the CONTRIBUTING.md and in greater detail in the online documentation.

Also one thing I recommend is to use pre-commit locally as detailed in the developer documentation, and set the hooks for pre-commit and pre-push, helps you keep your code tidy as you go!

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jun 22, 2024
@Adoni5 Adoni5 closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants