Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dorado Alignments #359

Closed
wants to merge 1 commit into from
Closed

Dorado Alignments #359

wants to merge 1 commit into from

Conversation

Adoni5
Copy link
Contributor

@Adoni5 Adoni5 commented Jun 18, 2024

Add some extension to the dorado plugin, causing it to set the alignments returned from dorado onto the basecalling result.

Not bothering with Guppy, as it's old.

Also sets reconnect_timeout and server_file_load_timeout to 10 on the PyBasecallClient by default meaning we timeout after 10 seconds rather than waiting for 5 minutes 5 times.

Add some code to the _mappy to create a PAF record from a list of fields, which is useful for converting the alignment data off the basecall record to a PAF.

Adds some documentation about using it to TOML.md.

Added the get_item function to deal with structured numpy arrays, which nested_get couldn't do ( I think ).

Notable

This method means it is absolutely possible to use both dorado to align as well as mappy, if mapper_settings isn't set to no_op.
Any thoughts?

@Adoni5 Adoni5 mentioned this pull request Jun 19, 2024
6 tasks
@Adoni5 Adoni5 requested review from alexomics and mattloose July 8, 2024 14:48
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Aug 23, 2024
@Adoni5 Adoni5 closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant