Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump all node 16 actions to node 20 #377

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Conversation

Adoni5
Copy link
Contributor

@Adoni5 Adoni5 commented Aug 26, 2024

Changes the uploading of coverage of tests data to use v4.
This requires a merging step, then a reupload, unlike before as the new action doesn't allow mutiple artifacts to be uploaded with the same name.

Copy link
Contributor Author

@Adoni5 Adoni5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #355

@Adoni5
Copy link
Contributor Author

Adoni5 commented Aug 26, 2024

Done - all relevant actions bumped to use node 20

mattloose
mattloose previously approved these changes Aug 27, 2024
Copy link
Contributor

@mattloose mattloose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's like magic.

@Adoni5 Adoni5 force-pushed the issue355/chore_update_actions branch from c7b5dca to 551b320 Compare August 27, 2024 10:42
@Adoni5 Adoni5 force-pushed the issue355/chore_update_actions branch from 551b320 to 8c8b344 Compare August 27, 2024 10:44
Copy link
Contributor

@mattloose mattloose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ands now it is even more magical than it was before.

@Adoni5 Adoni5 merged commit 64b9a7f into main Aug 27, 2024
10 checks passed
@Adoni5 Adoni5 deleted the issue355/chore_update_actions branch August 27, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants