libtrx/anims/common: move changes, ranges and commands to TRX #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a common accessor function to retrieve animation changes, although a temporary global g_AnimChanges remains until all calls are migrated.
This replaces all direct references to g_AnimChanges (other than level loading) to use Anim_GetChange.
This replaces all direct references to g_AnimChanges (other than level loading) to use Anim_GetChange.
This eliminates the g_AnimChanges global for both games and moves reading from level/injection files to libtrx.
This makes a common accessor function to retrieve animation changes, although a temporary global g_AnimRanges remains until all calls are migrated.
This replaces all direct references to g_AnimRanges (other than level loading) to use Anim_GetRange.
This replaces all direct references to g_AnimRanges (other than level loading) to use Anim_GetRange.
This eliminates the g_AnimRanges global for both games and moves reading from level/injection files to libtrx.
This moves the duplicated Item_GetAnimChange function to libtrx for both games.
This makes a common accessor function to retrieve animation commands, although a temporary global g_AnimCommands remains until all calls are migrated.
This replaces all direct references to g_AnimCommands (other than level loading) to use Anim_GetCommand.
This replaces all direct references to g_AnimCommands (other than level loading) to use Anim_GetCommand.
This eliminates the g_AnimCommands global for both games and moves reading from level/injection files to libtrx.
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
|
Download the built assets for this pull request: |
rr-
approved these changes
Jan 8, 2025
aredfan
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This migrates animation change, range and command storage to libtrx and introduces common accessors rather than using globals. These types are only used in
Lara_AnimateandItem_Animateand are related so I bundled them together in this PR. Same separate commit process as before with anims and bones.I would like to structure commands, but will defer this for the time being. As they are of variable size, and aren't needed for savegame state, I'm thinking we could add them directly to
ANIMrather than using a single list. But that's a future improvement I'd say.Next up will be frames.