Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Further cleanup for #2226.
Removes unused
SPRITE_FLAG
enums that I mistakenly looked up from TR2Main.Removes
0
from all empty struct initializers. This syntax is supported since ISO C23 (see 6.7.10 Initialization):Unfortunately we need
-Wno-gnu-empty-initializer
for Clang to recognize this.Removes ambiguity in controller binding declarations (specifically, the
bind
union) by introducing separate macros forBT_BUTTON
andBT_AXIS
.Adds
-Wno-gnu-binary-literal
to get Clang to recognize the binary literals, though this is also a part of the C23 standard. This has been fixed upstream, but has not yet found its way into our toolchain. Ref: [clang] Binary literals are flagged as a GNU extension even when compiling in C23 mode llvm/llvm-project#72017Adds
-Wno-gnu-zero-variadic-macro-arguments'
to get theGLYPH_DEFINE
macro to not produce invalid warnings. Passing zero variadic macro arguments is valid since C23. This has been fixed upstream, but has not yet found its way into our toolchain. Ref: Zero variable arguments should be allowed in C23 llvm/llvm-project#84495Fixes one case of an unitialized variable usage.