Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game flow rework (pt 8) #2391

Merged
merged 3 commits into from
Jan 26, 2025
Merged

Game flow rework (pt 8) #2391

merged 3 commits into from
Jan 26, 2025

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Jan 25, 2025 •
edited
Loading

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change
  • I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

  • TR1: Moves title level to its own sequence
  • TR1: Fixes typo in the documentation (it's not legacy, it's dummy)
  • TR1: Removes GFL_TITLE_DEMO_PC and GFL_LEVEL_DEMO_PC
  • TR1: Parses PC demo using some heuristics (the solution turned out to be not as bad as I expected)
  • TR1: Removes the need to supply type parameter for levels
  • TR1: Improves validation of the type parameter – only regular levels can set it to normal, bonus, gym, dummy, or current

@rr- rr- added Internal The invisible stuff TR1 labels Jan 25, 2025
@rr- rr- self-assigned this Jan 25, 2025
@rr- rr- requested review from a team as code owners January 25, 2025 23:08
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team January 25, 2025 23:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2025 •
edited
Loading

Download the built assets for this pull request:

rr- added 2 commits January 26, 2025 00:29
@rr-
tr1/level: replace GFL_*_DEMO_PC with heuristics
3a1357e
@rr-
tr1/game-flow: improve level type processing
17fbbaa 
- Removes the need to supply "normal" level type
- Makes it not possible to override levels placed in their dedicated
  sequences
- Makes it not possible to override level types to arbitrary level types
  (eg two title levels)
@rr- rr- merged commit d683751 into develop Jan 26, 2025
9 checks passed
@rr- rr- deleted the tr2-game-flow branch January 26, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aredfan aredfan aredfan approved these changes

@lahm86 lahm86 lahm86 approved these changes

@walkawayy walkawayy Awaiting requested review from walkawayy walkawayy is a code owner automatically assigned from LostArtefacts/dev

Assignees

@rr- rr-

Labels
Internal The invisible stuff TR1
Projects
TRX Dev tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rr- @lahm86 @aredfan