Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tr1/inv-ring: fix item counts staying at 1 #2392

Merged
merged 1 commit into from
Jan 26, 2025
Merged

tr1/inv-ring: fix item counts staying at 1 #2392

merged 1 commit into from
Jan 26, 2025
+1 −1

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Jan 25, 2025 •
edited
Loading

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change
  • I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

Resolves #2390. Regression made in 529d482.
Applies the same change for passport as 529d482 to TR2 while at it, but with the fix in place.

@rr- rr- added TRX bug A bug with TRX Unreleased Applies to things that aren't in a stable release. TR1 labels Jan 25, 2025
@rr- rr- self-assigned this Jan 25, 2025
@rr- rr- requested review from a team as code owners January 25, 2025 23:16
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team January 25, 2025 23:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2025 •
edited
Loading

Download the built assets for this pull request:

@rr- rr- force-pushed the issue-2390-inv-ring-item-count-1 branch from 697ec1f to 4365c87 Compare January 25, 2025 23:20
@rr- rr- merged commit 28eb2f8 into develop Jan 26, 2025
9 checks passed
@rr- rr- deleted the issue-2390-inv-ring-item-count-1 branch January 26, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aredfan aredfan aredfan approved these changes

@lahm86 lahm86 lahm86 approved these changes

@walkawayy walkawayy Awaiting requested review from walkawayy walkawayy is a code owner automatically assigned from LostArtefacts/dev

Assignees

@rr- rr-

Labels
TR1 TRX bug A bug with TRX Unreleased Applies to things that aren't in a stable release.
Projects
TRX Dev tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TR1X] [dev] Regular items are reduced to their minimum value and cannot be stacked
3 participants
@rr- @lahm86 @aredfan