Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix streaming channel ring buffer chunck management #495

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

houkhouk
Copy link

@houkhouk houkhouk commented Oct 22, 2024

By submiting this PR, you agree with the associated license MIT) and with our Contributor License Agreement (CLA).

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please follow these steps:

  • Ensure that this PR is not a duplicate.
  • Add the PR to the Luos contribution project

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.

PR Description section

Description and dependencies

Fixes the ring buffer management when having to split data between the end of the buffer and it beginning.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.
Improve stability of the network when heavily loaded (lots of nodes)


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault self-requested a review October 24, 2024 17:10
@nicolas-rabault nicolas-rabault mentioned this pull request Oct 24, 2024
8 tasks
@nicolas-rabault nicolas-rabault merged commit 3d58fdd into Luos-io:rc_3.1.0 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants