Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/vendor specific application #12

Merged

Conversation

luissimas
Copy link
Contributor

Hello!

While using the extension I've noticed that the format of the Vendor-Specific-Application-Id was not conforming to the expected grouped type described in the base protocol. This AVP is defined in section 6.11 of the RFC 6733.

This PR adds the configuration option for multiple Vendor-Specific-Application-Id AVPs.

Copy link
Contributor

@lwlee2608 lwlee2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks again

@lwlee2608 lwlee2608 merged commit e9b64f9 into MATRIXXSoftware:main Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants