[refactor] remove homography binary #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmichel-otb
approved these changes
Feb 25, 2019
dyoussef
approved these changes
Feb 27, 2019
carlodef
force-pushed
the
remove_homography_binary
branch
from
1be63be to
68ad552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
homographyc++ program with the Pythonaffine_cropfunction.homographywas used only with affine transforms so even if theaffine_cropfunction cannot be used to apply generic homographies to images it is enough for the usecase ofs2p.This opens the way to a reduction of the disk read/write as the tiles rectified with
affine_cropcould be passed in memory (as numpy arrays) to the stereo matching function. This will be done in a future pull request.