Switch to using a slug field for News items URLs. #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompollard
force-pushed
the
tp/news_slug
branch
2 times, most recently
from
a2a4f64 to
c173f66
Compare
All existing news items will be assigned their id as the slug, so paths will remain the same.
tompollard
force-pushed
the
tp/news_slug
branch
from
c173f66 to
e4833e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2143, we currently use sequential IDs for the path of news items. For example:
This pull request switches from IDs to a unique, user-defined slug. All existing news items will be assigned their id as the slug, so paths will remain the same. For example https://physionet.org/news/post/1 will continue to resolve after the migration.
In future work, we might want to: