Allow news items to be linked to all versions of a project #2186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, news items can only be linked to a single version of a published project, but in many or most cases we would actually like news items to link to all versions of a published project.
This pull request adds a flag to the news model that allows a news item to be linked to all versions of a project. Specifically, the changes are:
link_all_versions
flag to the News modelget_all_news()
method to thePublishedProject
model that makes it straightforward to retrieve all news items for the project (both news items that are directly linked, and news items that are linked through thelink_all_versions
flag).There may be better ways to implement this functionality, e.g. by:
project_version
to the News itemI would prefer to stick with the implementation in this pull request for timeliness (so that @briangow can respond to a user request). We can review and improve the approach in future.