add khronos object bindings #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Schmluk
commented
Aug 14, 2024
Schmluk
commented
- Adds python bindings for Khronos attributes.
nathanhhughes
approved these changes
Aug 14, 2024
Comment on lines
162
to
167
| .def_readwrite("trajectory_timestamps", | ||
| &KhronosObjectAttributes::trajectory_timestamps) | ||
| .def_readwrite("trajectory_positions", | ||
| &KhronosObjectAttributes::trajectory_positions) | ||
| .def_readwrite("dynamic_object_points", | ||
| &KhronosObjectAttributes::dynamic_object_points) |
There was a problem hiding this comment.
For future reference: these might be better as read-only (or opaque bindings). Otherwise there can be some weirdness with setting them on the python side and not seeing them on the c++ side (see here)
There was a problem hiding this comment.
Thanks for the pointer! Making these readonly for now, can reconsider in the future if we needed write access for some reason.
nathanhhughes
pushed a commit
that referenced
this pull request
Dec 12, 2024
* add khronos object bindings * make complex types readonly for safety for now
nathanhhughes
pushed a commit
that referenced
this pull request
Dec 12, 2024
* add khronos object bindings * make complex types readonly for safety for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.