Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more unit tests for default optional template parameter of VirtualConfig<> #39

Merged
merged 1 commit into from
Jan 13, 2025
Merged

feat: Add more unit tests for default optional template parameter of VirtualConfig<> #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions config_utilities/test/tests/virtual_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,19 @@ Warning: Check [1/1] failed: Virtual config is not set and not marked optional.
EXPECT_TRUE(isValid(config));
}

TEST(VirtualConfig, defaultOptional) {
{
constexpr bool kDefaultOptional = true;
VirtualConfig<Base2, kDefaultOptional> config;
EXPECT_TRUE(isValid(config));
}
{
constexpr bool kDefaultOptional = false;
VirtualConfig<Base2, kDefaultOptional> config;
EXPECT_FALSE(isValid(config));
}
}

TEST(VirtualConfig, printing) {
VirtualConfig<Base2> config;
std::string msg = toString(config);
Expand Down Expand Up @@ -384,4 +397,65 @@ TEST(VirtualConfig, optionalByDefault) {
EXPECT_EQ(object.valid.size(), 1u);
}

TEST(VirtualConfig, parseOptionalMissingField) {
{
constexpr bool kDefaultOptional = true;
YAML::Node data;
auto config = fromYaml<VirtualConfig<Base2, kDefaultOptional>>(data);
EXPECT_TRUE(isValid(config));
EXPECT_TRUE(config.optional());
}
{
constexpr bool kDefaultOptional = false;
YAML::Node data;
auto config = fromYaml<VirtualConfig<Base2, kDefaultOptional>>(data);
EXPECT_FALSE(isValid(config));
EXPECT_FALSE(config.optional());
}
}

TEST(VirtualConfig, parseOptionalFieldPresent) {
YAML::Node data;
data["type"] = "Derived2";
data["f"] = 1.f;
data["s"] = "blahblah";

{
constexpr bool kDefaultOptional = true;
auto config = fromYaml<VirtualConfig<Base2, kDefaultOptional>>(data);
EXPECT_TRUE(isValid(config));
EXPECT_TRUE(config.isSet());
EXPECT_EQ(config.getType(), "Derived2");
EXPECT_TRUE(config.optional());

auto actual_config = config.getUnderlying<Derived2::Config>();
ASSERT_TRUE(actual_config);
EXPECT_FLOAT_EQ(actual_config->f, 1.f);
EXPECT_EQ(actual_config->s, "blahblah");
}
{
constexpr bool kDefaultOptional = false;
auto config = fromYaml<VirtualConfig<Base2, kDefaultOptional>>(data);
EXPECT_TRUE(isValid(config));
EXPECT_TRUE(config.isSet());
EXPECT_EQ(config.getType(), "Derived2");
EXPECT_FALSE(config.optional());

auto actual_config = config.getUnderlying<Derived2::Config>();
ASSERT_TRUE(actual_config);
EXPECT_FLOAT_EQ(actual_config->f, 1.f);
EXPECT_EQ(actual_config->s, "blahblah");
}
}

TEST(VirtualConfig, optionalNullCreation) {
YAML::Node data;
constexpr bool kDefaultOptional = true;
auto config = fromYaml<VirtualConfig<Base2, kDefaultOptional>>(data);
ASSERT_TRUE(isValid(config));

auto object = config.create();
ASSERT_EQ(object, nullptr);
}

} // namespace config::test
Loading