Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shake Layout for Content #1301

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Shake Layout for Content #1301

merged 1 commit into from
Jan 25, 2025

Conversation

spaceninja
Copy link
Member

@spaceninja spaceninja commented Jan 25, 2025

Overview

This PR adjusts the layout of the shake page from the previous:

total = sidebar + pad + content + pad
960   = 325     + 40  + 555     + 40

To the updated:

total = sidebar + pad + content + pad
960   = 330     + 40  + 550     + 40

This better reflects our image intrinsic width of 550 from the CDN.

Testing

  • Review the shake page at various viewport sizes and ensure there are no regressions.

This PR adjusts the layout of the shake page from the previous:

total = sidebar + pad + content + pad
960   = 325     + 40  + 555     + 40

To the updated:

total = sidebar + pad + content + pad
960   = 330     + 40  + 550     + 40

This better reflects our image intrinsic width of 550 from the CDN.

Fixes #1280
@spaceninja spaceninja merged commit 5303534 into main Jan 25, 2025
6 checks passed
@spaceninja spaceninja deleted the bugfix/shake-layout branch January 25, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image content size for shake listings
1 participant