Kk/patches #53
Merged
Kk/patches #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- _add_columns function sets 'fc' column to false by default - we do not know if there are fcs or not so suggest setting to NA instead - added/tidied doc (a bit)
- while fiddling with earthscope notebooks, noticed doc for apply_bbox could use a tweak - return type was not correct
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## updates #53 +/- ##
===========================================
+ Coverage 33.22% 33.24% +0.01%
===========================================
Files 146 146
Lines 23976 23983 +7
===========================================
+ Hits 7965 7972 +7
Misses 16011 16011
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update _add_columns function
Minor change to doc
Motivation and Context
Aurora checks if there are na values in the fc column. It treats boolean values, False/True as if the FCs have been looked for and the answer is the entry in the dataframe. So, by setting them to False by default (and not None, or NA) aurora was assuming that the fcs had been sought and they were not present.
(I suppose I could tell aurora to look for them if the value was False or NA)....
simpeg/aurora#358
How Has This Been Tested?
Aurora's synthetic data processing example notebook runs ans now processes from FCs.
Active branch for /home/kkappler/software/irismt/aurora: patches
Active branch for /home/kkappler/software/irismt/mth5: patches
Active branch for /home/kkappler/software/irismt/mt_metadata: main
Active branch for /home/kkappler/software/irismt/mtpy-v2: kk/patches
Screenshots (if appropriate):
Before change
The
fccolumn in the below dataframe was allFalseWith change
Types of changes
Checklist: