Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Racing UI API #100

Merged
merged 18 commits into from
Jan 12, 2025
Merged

Racing UI API #100

merged 18 commits into from
Jan 12, 2025

Conversation

Greavesy1899
Copy link
Collaborator

First pass at exposing Racing HUDElement API using RaceXBin.

WIP PR, not going to commit as is. Feedback welcome

@Greavesy1899 Greavesy1899 added the enhancement New feature or request label Feb 27, 2024
@Greavesy1899 Greavesy1899 added this to the racing gamemode milestone Feb 27, 2024
@Greavesy1899 Greavesy1899 self-assigned this Feb 27, 2024
code/client/src/core/ui/world_debug.cpp Outdated Show resolved Hide resolved
code/client/src/core/ui/world_debug.cpp Outdated Show resolved Hide resolved
code/client/src/sdk/mafia/database/c_ui_database.cpp Outdated Show resolved Hide resolved
code/client/src/sdk/mafia/database/c_ui_database.h Outdated Show resolved Hide resolved
code/client/src/sdk/mafia/database/c_ui_database.h Outdated Show resolved Hide resolved
code/client/src/sdk/mafia/ui/hud/c_hud_controller.h Outdated Show resolved Hide resolved
code/client/src/sdk/mafia/ui/hud/race_xbin.cpp Outdated Show resolved Hide resolved
Comment on lines +18 to +19
// need to cast to C_UIDatabase
// TODO: Feels like this should be dynamic_cast, rather than reinterpret_cast
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we handle that comment now? not a big deal

Copy link
Collaborator Author

@Greavesy1899 Greavesy1899 Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Causes a crash using dynamic_cast, unsure why. I'll debug though.

code/client/src/sdk/mafia/ui/hud/race_xbin.cpp Outdated Show resolved Hide resolved
@Deewarz Deewarz requested review from Deewarz and Segfaultd March 6, 2024 20:57
code/client/src/sdk/patterns.h Outdated Show resolved Hide resolved
code/client/src/core/ui/world_debug.cpp Outdated Show resolved Hide resolved
code/client/src/sdk/mafia/database/c_ui_database.cpp Outdated Show resolved Hide resolved
@@ -90,10 +90,13 @@ namespace MafiaMP::Core {
ToggleVehicleDebug();
}

static bool bTempLockControls = false;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all temporary so I can test because ImGui cursor is currently broken. I'll likely remove it out from this PR when it has been approved.

@Segfaultd
Copy link
Member

Hey @Greavesy1899 what's the current status of this? I see all the comments have been addressed!

First thing is to sync this branch with the upstream (mainly LFS rip and other deps update etc...) but overall looks good.

@Greavesy1899
Copy link
Collaborator Author

@Segfaultd I've tested locally and made sure it compiles with latest changes - Some merge issues did occur - eg. imgui rework but should be resolved - pls check over to make sure

@Segfaultd Segfaultd merged commit 32a85fb into master Jan 12, 2025
@Segfaultd Segfaultd deleted the racing-ui branch January 12, 2025 17:46
@Greavesy1899 Greavesy1899 mentioned this pull request Jan 14, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants