Reversed IsEngineOn, GetSiren and GetBeaconLightsOn #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ehicle-improvements
…ehicle-improvements
…ehicle-improvements
Segfaultd
requested review from
Deewarz and
zpl-zak
and removed request for
Deewarz
zpl-zak
approved these changes
Feb 5, 2024
Deewarz
approved these changes
Feb 5, 2024
Deewarz
reviewed
Feb 5, 2024
Comment on lines
+23
to
+24
| ImGui::Text("Car Ptr: %p", currentCar); | ||
| ImGui::Text("Vehicle Ptr: %p", currentVehicle); |
There was a problem hiding this comment.
These are already at the bottom : https://github.com/MafiaHub/MafiaMP/pull/90/files#diff-9b678781c9bd580b6852983396c0fa61aee6c99734fc0e99a0f9c8a5f1419d97R178-R179
Deewarz
reviewed
Feb 5, 2024
Comment on lines
+105
to
+108
| bool isEngineOn = currentCar->IsEngineOn(); | ||
| if (ImGui::Checkbox("Engine", &isEngineOn)) { | ||
| currentVehicle->SetEngineOn(isEngineOn, isEngineOn); | ||
| } |
There was a problem hiding this comment.
Just to be sure, getter is on Car and setter on Vehicle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR closes #73
Won't address the TODOs for now so lets keep it like this