perf: Modifications to Configuration Parameters and Addition of Administrative Interfaces #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istrative Interfaces
1. Change the parameters from #[pallet::constant] to #[pallet::storage]
2. Add the functionality to initialize parameters in GenesisConfig
3. Add configuration interfaces:
```
set_system_ratio
set_treasury_ratio
set_operation_ratio
set_min_liquidation_threshold
set_profit_distribution_cycle
```
4. Add the ensure_root_or_admin function to check if the caller has sufficient permissions
merge from Main develop
perf: add configuration parameters and administrative interface
- Added boundary checks for the following parameters: - SystemRatio, TreasuryRatio, and OperationRatio: Ensure the sum is <= 100%. - MinLiquidationThreshold: Ensure it is greater than ExistentialDeposit. - ProfitDistributionCycle: Ensure it is greater than 1.
Fixed: Add boundary checks for ratio and threshold parameters
merge from Main develop
wd30130
previously approved these changes
Jun 26, 2024
Magnet release 0.7.0
Merge from Main develop
Fixed ratio sum > 100%
style: removed blank line
ExistentialDeposit error in mock
fixed: fixed MinLiquidationThreshold must be greater than ExistentialDeposit error in mock
fixed: fixed ratio sum > 100%
wd30130
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the parameters from #[pallet::constant] to #[pallet::storage]
Add the functionality to initialize parameters in GenesisConfig
Add configuration interfaces: