For Review Only #861
Open
For Review Only #861
+411
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardtfn
reviewed
Dec 19, 2024
| @@ -5,7 +5,7 @@ NeoPixel library helper functions for Methods. | |||
| Written by Michael C. Miller. | |||
|
|
|||
| I invest time and resources providing this open source code, | |||
| please support me by donating (see https://github.com/Makuna/NeoPixelBus) | |||
| please support me by dontating (see https://github.com/Makuna/NeoPixelBus) | |||
There was a problem hiding this comment.
Pretty sure that Typo has been there for a while. It's in the comments hardly relevant.
edwardtfn
reviewed
Dec 19, 2024
| @@ -4,7 +4,7 @@ NeoPixel library helper functions for Esp32. | |||
| Written by Michael C. Miller. | |||
|
|
|||
| I invest time and resources providing this open source code, | |||
| please support me by donating (see https://github.com/Makuna/NeoPixelBus) | |||
| please support me by dontating (see https://github.com/Makuna/NeoPixelBus) | |||
|
(I lost my house to a tree fall and I am more than little occupied, hang in there, I will get back to this) |
|
Oh no!! |
|
Oh dear, i was patiently waiting, though a little curious to why it was taking so so, but not in a hurry. I have plenty to develop for now. I probably could add the 32-bit version (like for the ESP8266) since the ESP32 is only the dual 16-bit. (one could call that the mysterious Pop-endian) Hope all is well and / or soon repaired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP32 I2S faster 3-step encoding, as well as DMX512 encoding