Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

Commit

Permalink
Merge pull request #9741 from ganeshhubale/rbac-fix
Browse files Browse the repository at this point in the history
[1LP][RFR] Fixed rbac tree issue on 5.11
  • Loading branch information
mshriver authored Dec 10, 2019
2 parents 018bdd3 + 5f8b6ec commit 095bb2a
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 8 deletions.
30 changes: 23 additions & 7 deletions cfme/tests/configure/test_access_control.py
Original file line number Diff line number Diff line change
Expand Up @@ -857,10 +857,22 @@ def test_role_crud(appliance):
casecomponent: Configuration
tags: rbac
"""
role = _mk_role(appliance, name=None, vm_restriction=None,
product_features=[(['Everything'], False),
(['Everything', 'Settings', 'Configuration'], True),
(['Everything', 'Services', 'Catalogs Explorer'], True)])
product_feature = (
['Everything', 'Configuration']
if appliance.version > "5.11"
else ['Everything', 'Settings', 'Configuration']
)

role = _mk_role(
appliance,
name=None,
vm_restriction=None,
product_features=[
(["Everything"], False),
(product_feature, True),
(["Everything", "Services", "Catalogs Explorer"], True),
],
)
with update(role):
role.name = "{}edited".format(role.name)
copied_role = role.copy()
Expand Down Expand Up @@ -1618,9 +1630,13 @@ def test_tenant_unique_catalog(appliance, request, catalog_obj):
'name': catalog_obj.name,
'description': catalog_obj.description
})
view.add_button.click()
view.flash.wait_displayed(timeout=20)
assert view.flash.read() == [msg]

if appliance.version > "5.11":
assert view.name.help_block == msg
else:
view.add_button.click()
view.flash.wait_displayed(timeout=20)
view.flash.assert_message(msg)


@pytest.mark.ignore_stream("upstream")
Expand Down
2 changes: 1 addition & 1 deletion widgetastic_manageiq/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4559,7 +4559,7 @@ def data_for_timestamp(self, timestamp):
return tooltip_data


class ReactTextInput(TextInput):
class ReactTextInput(Input):

# The clear method from the WebElement class in the Selenium package was not clearing the react
# text field. arguments[0] is the widget name
Expand Down

0 comments on commit 095bb2a

Please sign in to comment.