Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[WIP] Fixed drag_and_drop related issue #6262

Closed
wants to merge 1 commit into from
Closed

[WIP] Fixed drag_and_drop related issue #6262

wants to merge 1 commit into from

Conversation

Yadnyawalkya
Copy link
Member

{{pytest: -v cfme/tests/intelligence/test_dashboard.py -k test_drag_and_drop_widget_to_the_bottom_of_another_column}}

What was the issue?
There was no placeholder to hold last widget of column, whereas dashboard creates placeholder if you drop that widget between two widgets!

@Yadnyawalkya Yadnyawalkya changed the title [WIPTEST] Fixed drag_and_drop related issue [WIPTEST] Fixed drag_and_drop related issue Dec 22, 2017
@Yadnyawalkya Yadnyawalkya changed the title [WIPTEST] Fixed drag_and_drop related issue [RFR] Fixed drag_and_drop related issue Dec 22, 2017
Copy link
Contributor

@izapolsk izapolsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not sure that this is not BZ

@izapolsk
Copy link
Contributor

@Yadnyawalkya , @mfalesni, guys are you sure this is correct behaviour ? Maybe BZ ?

@izapolsk izapolsk requested a review from mfalesni December 25, 2017 10:07
@izapolsk izapolsk changed the title [RFR] Fixed drag_and_drop related issue [1LP][RFR] Fixed drag_and_drop related issue Dec 25, 2017
@Yadnyawalkya
Copy link
Member Author

@izapolsk @mfalesni: I can drag and drop DashboardWidget and process works well manually but it is not going well with automation. I am discussing this issue here: #6268, let me know your view on this!

Although, this workaround works superfine and can stabilize test from failing.

@izapolsk
Copy link
Contributor

@Yadnyawalkya, thanks, I see that this fix works fine. However, I'd like to be sure that it doesn't make test useless. So, I'd like to know @mfalesni opinion.

@jkrocil
Copy link
Contributor

jkrocil commented Jan 2, 2018

I vaguely remember this (not being able to drop items at the end of a list) being a "feature" of the library used for drag-n-drop in ManageIQ but I would wait for @mfalesni to confirm as well.

@izapolsk
Copy link
Contributor

izapolsk commented Jan 5, 2018

@jkrocil, I think so too. That's the reason why I have not merged this PR yet. It seems BZ should be raised instead and test should be blocked.

Copy link
Contributor

@psav psav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejecting this as per the comments

@psav psav changed the title [1LP][RFR] Fixed drag_and_drop related issue [WIP] Fixed drag_and_drop related issue Jan 5, 2018
@dajoRH dajoRH added the WIP label Jan 5, 2018
@dajoRH
Copy link
Contributor

dajoRH commented Jan 15, 2018

Would you mind rebasing this Pull Request against latest master, please? :trollface:
CFME QE Bot

@Yadnyawalkya
Copy link
Member Author

Closing this due to #6418! @mfalesni was it bug? should I close this issue #6268 too?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants