-
Notifications
You must be signed in to change notification settings - Fork 165
[WIP] Fixed drag_and_drop related issue #6262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm not sure that this is not BZ
@Yadnyawalkya , @mfalesni, guys are you sure this is correct behaviour ? Maybe BZ ? |
@Yadnyawalkya, thanks, I see that this fix works fine. However, I'd like to be sure that it doesn't make test useless. So, I'd like to know @mfalesni opinion. |
I vaguely remember this (not being able to drop items at the end of a list) being a "feature" of the library used for drag-n-drop in ManageIQ but I would wait for @mfalesni to confirm as well. |
@jkrocil, I think so too. That's the reason why I have not merged this PR yet. It seems BZ should be raised instead and test should be blocked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rejecting this as per the comments
Would you mind rebasing this Pull Request against latest master, please? |
{{pytest: -v cfme/tests/intelligence/test_dashboard.py -k test_drag_and_drop_widget_to_the_bottom_of_another_column}}
What was the issue?
There was no placeholder to hold last widget of column, whereas dashboard creates placeholder if you drop that widget between two widgets!