-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][WIP] Fix preemtivity in test_gce_preemptible_provision. #7674
base: master
Are you sure you want to change the base?
Conversation
@@ -97,9 +98,10 @@ def test_provision_from_template(provider, provisioned_instance): | |||
@pytest.mark.provider([GCEProvider], required_fields=[['provisioning', 'image']], | |||
override=True) | |||
@pytest.mark.usefixtures('setup_provider') | |||
@pytest.mark.meta(blockers=[BZ(1619298)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This BZ is for 5.9 only
@pytest.mark.meta(blockers=[BZ(1619298, forced_streams=['5.9'])])
Modified pytest statement in PR description, since it needs to collect against GCE. The K filter that was there to select the test wasn't working either. |
@@ -97,9 +98,10 @@ def test_provision_from_template(provider, provisioned_instance): | |||
@pytest.mark.provider([GCEProvider], required_fields=[['provisioning', 'image']], | |||
override=True) | |||
@pytest.mark.usefixtures('setup_provider') | |||
@pytest.mark.meta(blockers=[BZ(1619298, forced_streams=['5.9', '5.10'])]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't blocking on 59 in PRT, and the test fails with GCE Instance isn't Preemptible (cfme/tests/cloud_infra_common/test_provisioning.py:110)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is caused by #7661
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looked good, but PRT is showing test failure in 59z and no blocking.
@JaryN would you still like to have this changed merged? Please close or rebase. Thanks! |
@mshriver I rebased this, but I am not sure do I want to work on getting this in. I didn't see the any GCE test runing for quite a while. |
Lint report for commit f51ed1f:
Please, rectify these issues 😏 . No commit flaws detected. CFME QE Bot |
Purpose or Intent
{{ pytest: -v cfme/tests/cloud_infra_common/test_provisioning.py::test_gce_preemptible_provision --use-provider gce_central }}