Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][WIP] Fix preemtivity in test_gce_preemptible_provision. #7674

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[1LP][WIP] Fix preemtivity in test_gce_preemptible_provision. #7674

wants to merge 2 commits into from

Conversation

jarovo
Copy link
Contributor

@jarovo jarovo commented Aug 20, 2018

Purpose or Intent

  • Fixing test test_gce_preemptible_provision currently failing to set VM as preemptible during creation process.
  • Marking it as blocked as the created VM is not reported as being preemtive.

{{ pytest: -v cfme/tests/cloud_infra_common/test_provisioning.py::test_gce_preemptible_provision --use-provider gce_central }}

@jarovo jarovo changed the title Fix preemtivity in test_gce_preemptible_provision. [RFR] Fix preemtivity in test_gce_preemptible_provision. Aug 21, 2018
@@ -97,9 +98,10 @@ def test_provision_from_template(provider, provisioned_instance):
@pytest.mark.provider([GCEProvider], required_fields=[['provisioning', 'image']],
override=True)
@pytest.mark.usefixtures('setup_provider')
@pytest.mark.meta(blockers=[BZ(1619298)])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This BZ is for 5.9 only
@pytest.mark.meta(blockers=[BZ(1619298, forced_streams=['5.9'])])

@sshveta sshveta changed the title [RFR] Fix preemtivity in test_gce_preemptible_provision. [WIP] Fix preemtivity in test_gce_preemptible_provision. Aug 23, 2018
@jarovo jarovo changed the title [WIP] Fix preemtivity in test_gce_preemptible_provision. [RFR] Fix preemtivity in test_gce_preemptible_provision. Aug 31, 2018
@dajoRH dajoRH removed the WIP label Aug 31, 2018
izapolsk
izapolsk approved these changes Sep 4, 2018
@izapolsk izapolsk changed the title [RFR] Fix preemtivity in test_gce_preemptible_provision. [1LP][RFR] Fix preemtivity in test_gce_preemptible_provision. Sep 4, 2018
@mshriver
Copy link
Member

mshriver commented Sep 5, 2018

Modified pytest statement in PR description, since it needs to collect against GCE. The K filter that was there to select the test wasn't working either.

@@ -97,9 +98,10 @@ def test_provision_from_template(provider, provisioned_instance):
@pytest.mark.provider([GCEProvider], required_fields=[['provisioning', 'image']],
override=True)
@pytest.mark.usefixtures('setup_provider')
@pytest.mark.meta(blockers=[BZ(1619298, forced_streams=['5.9', '5.10'])])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't blocking on 59 in PRT, and the test fails with GCE Instance isn't Preemptible (cfme/tests/cloud_infra_common/test_provisioning.py:110)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is caused by #7661

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshriver could you please fix the #7661 to unblock this PR? Thanks.

Copy link
Member

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looked good, but PRT is showing test failure in 59z and no blocking.

@mshriver mshriver changed the title [1LP][RFR] Fix preemtivity in test_gce_preemptible_provision. [1LP][WIP] Fix preemtivity in test_gce_preemptible_provision. Sep 5, 2018
@dajoRH dajoRH added the WIP label Sep 5, 2018
@dajoRH dajoRH added needs-lint and removed lint-ok labels Jan 17, 2019
@mshriver
Copy link
Member

mshriver commented Oct 23, 2019

@JaryN would you still like to have this changed merged? Please close or rebase. Thanks!

@jarovo
Copy link
Contributor Author

jarovo commented Jan 31, 2020

@mshriver I rebased this, but I am not sure do I want to work on getting this in. I didn't see the any GCE test runing for quite a while.

@dajoRH
Copy link
Contributor

dajoRH commented Jan 31, 2020

Lint report for commit f51ed1f:

cfme/tests/cloud_infra_common/test_provisioning.py:

  • 🔴 Line 108:29: F821 undefined name 'GH'

Please, rectify these issues 😏 .

No commit flaws detected.

CFME QE Bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants